Mark rust-analyzer as a host-only tool
#103246
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All tools meant to be shipped with host toolchains only should be marked as `ONLY_HOSTS = true`, but rust-analyzer was marked as `ONLY_HOSTS = false` incorrectly. This meant that bootstrap attempted to build rust-analyzer for cross-compilation-only targets, causing errors because libstd is not present on some of them. It will still be possible to cross-compile rust-analyzer by passing a different --host flag to ./x, like you can cross-compile other tools.
rustbot
added
the
T-bootstrap
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
| @@ -742,7 +742,7 @@ pub struct RustAnalyzerProcMacroSrv { | |||
| impl Step for RustAnalyzerProcMacroSrv { | |||
| type Output = Option<PathBuf>; | |||
| const DEFAULT: bool = true; | |||
| const ONLY_HOSTS: bool = false; | |||
| const ONLY_HOSTS: bool = true; | |||
There was a problem hiding this comment.
I'm not sure this is right. Isn't this libproc_macro but for rust-analyzer? IOW, shouldn't it be shipped whenever we ship std?
There was a problem hiding this comment.
No, we should ship this wherever we ship a host compiler. The binary provides a stable interface between rust-analyzer and the current compiler's proc macro implementation, so there should be no point in shipping it outside of host toolchains.
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 19, 2022
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#103211 (rustdoc: remove class name `location` from sidebar sibling nav) - rust-lang#103223 (Use already checked RHS ty for LHS deref suggestions) - rust-lang#103237 (Clean up codeblock-tooltip rustdoc-gui test) - rust-lang#103239 (Allow #[unstable] impls for fn() with unstable abi.) - rust-lang#103246 (Mark `rust-analyzer` as a host-only tool) - rust-lang#103257 (rustdoc: move `setting-line` color CSS to settings.css) - rust-lang#103258 (Make miri read_dir test a little more robust) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Aaron1011
pushed a commit
to Aaron1011/rust
that referenced
this pull request
Jan 6, 2023
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#103211 (rustdoc: remove class name `location` from sidebar sibling nav) - rust-lang#103223 (Use already checked RHS ty for LHS deref suggestions) - rust-lang#103237 (Clean up codeblock-tooltip rustdoc-gui test) - rust-lang#103239 (Allow #[unstable] impls for fn() with unstable abi.) - rust-lang#103246 (Mark `rust-analyzer` as a host-only tool) - rust-lang#103257 (rustdoc: move `setting-line` color CSS to settings.css) - rust-lang#103258 (Make miri read_dir test a little more robust) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All tools meant to be shipped with host toolchains only should be marked as
ONLY_HOSTS = true, but rust-analyzer was marked asONLY_HOSTS = falseincorrectly. This meant that bootstrap attempted to build rust-analyzer for cross-compilation-only targets, causing errors because libstd is not present on some of them.It will still be possible to cross-compile rust-analyzer by passing a different
--hostflag to./x, like you can cross-compile other tools.The problem can be reproduced by running: